Ticket #7 (closed enhancement: fixed)

Opened 7 months ago

Last modified 7 months ago

Removal of copy.deepcopy from MemberResource.from_entry

Reported by: guest Assigned to: sylvain
Priority: major Milestone: amplee-0.6.1
Component: amplee Version: amplee-0.6.0
Keywords: Cc:

Description

It seems that the copy.deepcopy in here is unnecessary.

The patch is:

=== modified file 'amplee/atompub/member/init.py' --- amplee/atompub/member/init.py 2008-04-13 08:58:52 +0000 +++ amplee/atompub/member/init.py 2008-04-21 08:00:06 +0000 @@ -117,8 +117,8 @@

@param entry: atom entry attached to the L{MemberResource?} instance.

Sets the instance attribute to the values extracted from the entry.

"""

- self.entry = copy.deepcopy(entry).ownerDocument - + self.entry = entry.ownerDocument +

entry.ownerDocument.xmlns_prefixes.update({ATOM10_PREFIX: ATOM10_NS,

ATOMPUB_PREFIX: ATOMPUB_NS})

self.member_id = self.generate_resource_id(entry=entry, info=info)

Change History

05/07/08 09:46:57 changed by sylvain

  • version changed from Current to amplee-0.6.1.

05/07/08 09:59:15 changed by sylvain

  • version changed from amplee-0.6.1 to amplee-0.6.0.
  • milestone set to amplee-0.6.1.

05/08/08 04:18:18 changed by sylvain

  • status changed from new to closed.
  • resolution set to fixed.

Fixed in [653]. Thanks to Mohan.